Discussion:
[Thinkfinger-devel] [patch] 0.2.2 and 0.2.3 - Add 'debug' to the pam module.
Jose Plans
2007-02-24 17:29:00 UTC
Permalink
Hi all,

Attached you will find two patches for each tree adding the debug
option for the pam module. Both follow the same principle, the only
difference is 0.2.3 which debugs uinput and reacts accordingly.

For those using Fedora Core (5,6) / RHEL - CentOS (check libusb there)
you can find nightly builds in :

* http://belial.dead.li/~jmp/thinkfinger/

And patches.

Thanks,

Jose
Jose Plans
2007-02-24 17:31:17 UTC
Permalink
Post by Jose Plans
Hi all,
Attached you will find two patches for each tree adding the debug
option for the pam module. Both follow the same principle, the only
difference is 0.2.3 which debugs uinput and reacts accordingly.
Sorry, I forgot to include the man page change on 0.2.3, Timo could you
do that? the patch should apply cleanly from the 0.2.2 one.

Thanks!

Jose
Jose Plans
2007-02-25 00:53:09 UTC
Permalink
Post by Jose Plans
Hi all,
Attached you will find two patches for each tree adding the debug
option for the pam module. Both follow the same principle, the only
difference is 0.2.3 which debugs uinput and reacts accordingly.
Small change.

Jose
Timo Hoenig
2007-02-27 10:18:32 UTC
Permalink
Hi Jose,
Post by Jose Plans
Post by Jose Plans
Hi all,
Attached you will find two patches for each tree adding the debug
option for the pam module. Both follow the same principle, the only
difference is 0.2.3 which debugs uinput and reacts accordingly.
Small change.
I will first commit the 0.2.3 bits to SVN and then apply your patches on
top of it.

Thanks for working on this!

Timo
Timo Hoenig
2007-02-27 15:21:26 UTC
Permalink
Post by Timo Hoenig
I will first commit the 0.2.3 bits to SVN and then apply your patches on
top of it.
Thanks for working on this!
I have applied the attached patch to SVN. It also includes the man page
changes and some cleanups. We should also mention the debug option in
the README.

Some strings and coding style slightly differ from your original patch
and I have also removed

137 -+ if (!pam_tf_debug)
138 -+ pam_thinkfinger_log (LOG_INFO, "debug turned off by default.");

as there is no code path leading there.

That's it -- thanks,

Timo

Loading...