Luca Capello
2008-03-03 23:46:54 UTC
Hello!
After Christian Neumair patchset was included upstream [1], tf-tool
should have been moved to /usr/bin, for two reasons:
1) according to the FHS-2.3 [2]
/usr/sbin : Non-essential standard system binaries
This directory contains any non-essential binaries used exclusively
by the system administrator. System administration programs that
are required for system repair, system recovery, mounting /usr, or
other essential functions must be placed in /sbin instead.
Indeed, now that every single user can have a fingerprint stored in
her/his $HOME, tf-tool (AFAIK the only tool to acquire fingerprints
for ThinkFinger) is no more "used exclusively by the system
administrator".
2) a non-root user $PATH by default doesn't include /usr/sbin, which
means that more documentation should be added to inform the user that
tf-tool is in /usr/sbin and it should be called with the full path.
The following patch install tf-tool into /usr/bin instead:
--8<---------------cut here---------------start------------->8---
diff -Naur thinkfinger.ORG/configure.in thinkfinger/configure.in
--- thinkfinger.ORG/configure.in 2008-03-03 23:57:27.000000000 +0100
+++ thinkfinger/configure.in 2008-03-03 23:54:37.000000000 +0100
@@ -111,7 +111,7 @@
fi
exec_prefix=$EXEC_PREFIX
-# AC_SUBST PREFIX, LIBDIR, BINDIR, SBINDIR, MANDIR, SECUREDIR and BIRDIR
+# AC_SUBST PREFIX, LIBDIR, BINDIR, MANDIR, SECUREDIR and BIRDIR
PREFIX_TMP="$prefix"
PREFIX=`eval echo $PREFIX_TMP`
AC_SUBST(PREFIX)
@@ -124,10 +124,6 @@
BINDIR=`eval echo $BINDIR_TMP`
AC_SUBST(BINDIR)
-SBINDIR_TMP="$sbindir"
-SBINDIR=`eval echo $SBINDIR_TMP`
-AC_SUBST(SBINDIR)
-
if ! test -z "$with_securedir" ; then
SECUREDIR_TMP="$with_securedir"
else
@@ -203,7 +199,6 @@
+ prefix: ${PREFIX}
+ libdir: ${LIBDIR}
+ bindir: ${BINDIR}
- + sbindir: ${SBINDIR}
+ mandir: ${MANDIR}
+ cflags: ${CFLAGS}
diff -Naur thinkfinger.ORG/tf-tool/Makefile.am thinkfinger/tf-tool/Makefile.am
--- thinkfinger.ORG/tf-tool/Makefile.am 2008-03-03 23:57:27.000000000 +0100
+++ thinkfinger/tf-tool/Makefile.am 2008-03-03 23:54:37.000000000 +0100
@@ -1,4 +1,4 @@
-sbin_PROGRAMS = tf-tool
+bin_PROGRAMS = tf-tool
INCLUDES = -I$(top_srcdir)/libthinkfinger
--8<---------------cut here---------------end--------------->8---
FWIW, this patch should be applied after the tf-tool_completion patch
for `make dist*` [3]. And FYI it will be included in the next Debian
package if no one replies against it in the next two days.
Thx, bye,
Gismo / Luca
Footnotes:
[1] http://thread.gmane.org/gmane.linux.drivers.thinkfinger/424/focus=491
[2] http://www.pathname.com/fhs/pub/fhs-2.3.html#USRSBINNONESSENTIALSTANDARDSYSTEMBI
[3] http://thread.gmane.org/gmane.linux.drivers.thinkfinger/525
After Christian Neumair patchset was included upstream [1], tf-tool
should have been moved to /usr/bin, for two reasons:
1) according to the FHS-2.3 [2]
/usr/sbin : Non-essential standard system binaries
This directory contains any non-essential binaries used exclusively
by the system administrator. System administration programs that
are required for system repair, system recovery, mounting /usr, or
other essential functions must be placed in /sbin instead.
Indeed, now that every single user can have a fingerprint stored in
her/his $HOME, tf-tool (AFAIK the only tool to acquire fingerprints
for ThinkFinger) is no more "used exclusively by the system
administrator".
2) a non-root user $PATH by default doesn't include /usr/sbin, which
means that more documentation should be added to inform the user that
tf-tool is in /usr/sbin and it should be called with the full path.
The following patch install tf-tool into /usr/bin instead:
--8<---------------cut here---------------start------------->8---
diff -Naur thinkfinger.ORG/configure.in thinkfinger/configure.in
--- thinkfinger.ORG/configure.in 2008-03-03 23:57:27.000000000 +0100
+++ thinkfinger/configure.in 2008-03-03 23:54:37.000000000 +0100
@@ -111,7 +111,7 @@
fi
exec_prefix=$EXEC_PREFIX
-# AC_SUBST PREFIX, LIBDIR, BINDIR, SBINDIR, MANDIR, SECUREDIR and BIRDIR
+# AC_SUBST PREFIX, LIBDIR, BINDIR, MANDIR, SECUREDIR and BIRDIR
PREFIX_TMP="$prefix"
PREFIX=`eval echo $PREFIX_TMP`
AC_SUBST(PREFIX)
@@ -124,10 +124,6 @@
BINDIR=`eval echo $BINDIR_TMP`
AC_SUBST(BINDIR)
-SBINDIR_TMP="$sbindir"
-SBINDIR=`eval echo $SBINDIR_TMP`
-AC_SUBST(SBINDIR)
-
if ! test -z "$with_securedir" ; then
SECUREDIR_TMP="$with_securedir"
else
@@ -203,7 +199,6 @@
+ prefix: ${PREFIX}
+ libdir: ${LIBDIR}
+ bindir: ${BINDIR}
- + sbindir: ${SBINDIR}
+ mandir: ${MANDIR}
+ cflags: ${CFLAGS}
diff -Naur thinkfinger.ORG/tf-tool/Makefile.am thinkfinger/tf-tool/Makefile.am
--- thinkfinger.ORG/tf-tool/Makefile.am 2008-03-03 23:57:27.000000000 +0100
+++ thinkfinger/tf-tool/Makefile.am 2008-03-03 23:54:37.000000000 +0100
@@ -1,4 +1,4 @@
-sbin_PROGRAMS = tf-tool
+bin_PROGRAMS = tf-tool
INCLUDES = -I$(top_srcdir)/libthinkfinger
--8<---------------cut here---------------end--------------->8---
FWIW, this patch should be applied after the tf-tool_completion patch
for `make dist*` [3]. And FYI it will be included in the next Debian
package if no one replies against it in the next two days.
Thx, bye,
Gismo / Luca
Footnotes:
[1] http://thread.gmane.org/gmane.linux.drivers.thinkfinger/424/focus=491
[2] http://www.pathname.com/fhs/pub/fhs-2.3.html#USRSBINNONESSENTIALSTANDARDSYSTEMBI
[3] http://thread.gmane.org/gmane.linux.drivers.thinkfinger/525