Discussion:
[Thinkfinger-devel] Choice of libusb >= 0.1.12
Jose Plans
2007-02-21 16:20:49 UTC
Permalink
Hi all,

Is there any reason why libthinkfinger is limited to libusb 0.1.12 ?
After checking differences for linux on both libusb 0.1.11 and 0.1.12
there is a memory leak fix and some endians. Would it be safe to remove
from the configure the limitation to 0.1.11 ? Or shall we limit the spec
file to BuildRequire: libusb-devel >= 0.1.12 ?

This limits its usage to FedoraCore6 and onwards making the portage to
FedoraCore5 not possible.

thanks,

Jose
Timo Hoenig
2007-02-21 18:42:17 UTC
Permalink
Post by Jose Plans
Is there any reason why libthinkfinger is limited to libusb 0.1.12 ?
After checking differences for linux on both libusb 0.1.11 and 0.1.12
there is a memory leak fix and some endians. Would it be safe to remove
from the configure the limitation to 0.1.11 ? Or shall we limit the spec
file to BuildRequire: libusb-devel >= 0.1.12 ?
I've chosen to depend on 0.1.12 as I was developing libthinkfinger using
that version. Don't you have libusb 0.1.12 for FC5? Otherwise I have
no real objections towards loosening the requirement.

Timo
Jose Plans
2007-02-21 22:07:26 UTC
Permalink
Post by Timo Hoenig
Post by Jose Plans
Is there any reason why libthinkfinger is limited to libusb 0.1.12 ?
After checking differences for linux on both libusb 0.1.11 and 0.1.12
there is a memory leak fix and some endians. Would it be safe to remove
from the configure the limitation to 0.1.11 ? Or shall we limit the spec
file to BuildRequire: libusb-devel >= 0.1.12 ?
I've chosen to depend on 0.1.12 as I was developing libthinkfinger using
that version. Don't you have libusb 0.1.12 for FC5? Otherwise I have
no real objections towards loosening the requirement.
Ok, let me check if anything breaks :-)
Cheers Timo!

Jose
Timo Hoenig
2007-02-22 07:30:47 UTC
Permalink
Hi Jose,
Post by Jose Plans
Ok, let me check if anything breaks :-)
Cheers Timo!
Please let me know the results so we can adjust that requirement.

Thanks,

Timo
Jose Plans
2007-02-22 09:20:21 UTC
Permalink
Post by Timo Hoenig
Hi Jose,
Post by Jose Plans
Ok, let me check if anything breaks :-)
Cheers Timo!
Please let me know the results so we can adjust that requirement.
OK no problems so far on FC5 libusb 0.1.11.
I have just changed the configure file to revert 0.1.12 to 0.1.11 to
avoid changes on the FC Extras SPEC.

On another subject is there any Bugzilla for libthinkfinger /
pam_thinkfinger, or you guys track bugs on sf.net and mailing lists ?

Thanks!

Jose
Timo Hoenig
2007-02-22 09:34:37 UTC
Permalink
Post by Jose Plans
OK no problems so far on FC5 libusb 0.1.11.
I have just changed the configure file to revert 0.1.12 to 0.1.11 to
avoid changes on the FC Extras SPEC.
Hence, the following would be nice to have upstream to make it work on
FC5?

Index: configure.in
===================================================================
--- configure.in (revision 73)
+++ configure.in (working copy)
@@ -61,7 +61,7 @@
AC_ARG_ENABLE(birdir, AC_HELP_STRING([--with-birdir=dir],[Where to put the biometric identification records (bir files) @<:@default=$sysconfdir/pam_thinkfinger@:>@]))

# Check for libusb using pkg-config
-PKG_CHECK_MODULES(USB, libusb >= 0.1.12, usb_found=yes, AC_MSG_ERROR([libusb missing]))
+PKG_CHECK_MODULES(USB, libusb >= 0.1.11, usb_found=yes, AC_MSG_ERROR([libusb missing]))

# Check for Doxygen
AC_CHECK_PROG(DOXYGEN, [doxygen], [doxygen], [])
Post by Jose Plans
On another subject is there any Bugzilla for libthinkfinger /
pam_thinkfinger, or you guys track bugs on sf.net and mailing lists ?
No, there's no dedicated bugzilla for ThinkFinger. I check the sf.net
tracker on a regular base, though.

Timo
Jose Plans
2007-02-22 09:42:16 UTC
Permalink
Post by Timo Hoenig
Post by Jose Plans
OK no problems so far on FC5 libusb 0.1.11.
I have just changed the configure file to revert 0.1.12 to 0.1.11 to
avoid changes on the FC Extras SPEC.
Hence, the following would be nice to have upstream to make it work on
FC5?
;-) That's it!
Post by Timo Hoenig
No, there's no dedicated bugzilla for ThinkFinger. I check the sf.net
tracker on a regular base, though.
fine by me! thanks lots!

Jose
Timo Hoenig
2007-02-22 09:51:54 UTC
Permalink
Post by Jose Plans
;-) That's it!
I've committed that to SVN.
Post by Jose Plans
Post by Timo Hoenig
No, there's no dedicated bugzilla for ThinkFinger. I check the sf.net
tracker on a regular base, though.
fine by me! thanks lots!
OK. I guess it will work out fine if we solve distribution specific
problems on relevant bug tracking systems. For upstream bugs we can use
this list and the sf.net tracker.

Thanks,

Timo

Loading...