Christian Neumair
2007-08-12 09:36:07 UTC
Dear thinkfinger-devel mailing list,
I've sent a similar message to the author of thinkfinger, Timo Hoenig,
in April, but he didn't have time for a review. I'm now sending it to
the mailing list so that it doesn't get lost:
The attached patches convey some small improvement and fixes, and also
allow people to store the fingerprints in their home directories instead
of using a global directory.
* tf-01-debug.diff: more verbosity for USB (de)initialization and for
errors while opening BIR files
* tf-02-unlink.diff: remove BIR file when acquisition fails. One could
also write to targetfile.bir.new before, and overwrite the old file
after acquisition using unlink/rename upon success.
* tf-03-strdup.diff: libthinkfinger should maintain an own copy of the
passed-in file name. I've developed a GUI application on top of
libthinkfinger, and it uses dynamic allocation for the file name. One
could also implement length asserts.
* tf-04-tf-tool.diff: Removed PAM ifdef, write to ~/.thinkfinger.bir by
default, but optionally to a custom path.
* tf-05-pam.diff: Make PAM look at ~/.thinkfinger.bir by default, fall
back to /etc/thinkfinger/username.bir for compatibility.
Other things:
I had some propblems with a GUI client that uses two threads, a
libthinkfinger worker thread, and a conventional GTK+ main thread with a
main loop.
When sending a SIGINT, the libthinkfinger thread is terminated
correctly, and libthinkfinger_free() is called,
but at the next libthinkfinger_new() call the status is suddently
TF_STATE_SIGINT. Possibly _libthinkfinger_usb_deinit
should set "termination_request = 0x00" to, or it should be reset in the
beginning of _init or _new routines.
It would also be nice if libthinkfinger could listen to SIGUSR1, since I
need SIGINT for the debugger.
I'm also attaching a udev rule, which I use to allow normal users in the
group "fingerprint" to access the reader. This allows normal users to
use tf-tool (and my GUI application), which is a prerequisite for
user-friendly fingerprint usage.
If anybody of you is interested in the code for the libthinkfinger GUI,
I can publish it as well.
I've sent a similar message to the author of thinkfinger, Timo Hoenig,
in April, but he didn't have time for a review. I'm now sending it to
the mailing list so that it doesn't get lost:
The attached patches convey some small improvement and fixes, and also
allow people to store the fingerprints in their home directories instead
of using a global directory.
* tf-01-debug.diff: more verbosity for USB (de)initialization and for
errors while opening BIR files
* tf-02-unlink.diff: remove BIR file when acquisition fails. One could
also write to targetfile.bir.new before, and overwrite the old file
after acquisition using unlink/rename upon success.
* tf-03-strdup.diff: libthinkfinger should maintain an own copy of the
passed-in file name. I've developed a GUI application on top of
libthinkfinger, and it uses dynamic allocation for the file name. One
could also implement length asserts.
* tf-04-tf-tool.diff: Removed PAM ifdef, write to ~/.thinkfinger.bir by
default, but optionally to a custom path.
* tf-05-pam.diff: Make PAM look at ~/.thinkfinger.bir by default, fall
back to /etc/thinkfinger/username.bir for compatibility.
Other things:
I had some propblems with a GUI client that uses two threads, a
libthinkfinger worker thread, and a conventional GTK+ main thread with a
main loop.
When sending a SIGINT, the libthinkfinger thread is terminated
correctly, and libthinkfinger_free() is called,
but at the next libthinkfinger_new() call the status is suddently
TF_STATE_SIGINT. Possibly _libthinkfinger_usb_deinit
should set "termination_request = 0x00" to, or it should be reset in the
beginning of _init or _new routines.
It would also be nice if libthinkfinger could listen to SIGUSR1, since I
need SIGINT for the debugger.
I'm also attaching a udev rule, which I use to allow normal users in the
group "fingerprint" to access the reader. This allows normal users to
use tf-tool (and my GUI application), which is a prerequisite for
user-friendly fingerprint usage.
If anybody of you is interested in the code for the libthinkfinger GUI,
I can publish it as well.
--
Christian Neumair <***@gnome-de.org>
Christian Neumair <***@gnome-de.org>